[DataGrid] Refactor: move Badge to leaf import #15879
Merged
+52
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgrk
added
the
component: data grid
|
Deploy preview: https://deploy-preview-15879--material-ui-x.netlify.app/ |
michelengelen
approved these changes
Dec 16, 2024
| @@ -131,6 +149,18 @@ export interface GridSlotProps { | |||
| toolbar: GridToolbarProps & ToolbarPropsOverrides; | |||
| } | |||
|
|
|||
| /* Merge MUI types into base types to keep slotProps working. */ | |||
| type Merge<A, B> = { | |||
There was a problem hiding this comment.
Shouldn't we define this in a more general (utils) space? This seems as if it could be useful elsewhere as well!
There was a problem hiding this comment.
It's not used anywhere at the moment, I'd wait until it's used twice at least.
KenanYusuf
approved these changes
Dec 16, 2024
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design-agnostic OKR.
Move
Badgeto a leaf import.